[Nice] [PATCH] Make set_remote_candidates return the correct value

Rohan Garg rohan16garg at gmail.com
Fri Mar 30 12:00:22 PDT 2012

A follow up remark, the documentation says that it returns -1 on a
error, depending on whether or not you consider a invalid NiceAddress
a error, this patch may/may not be relevant.

Rohan Garg

On Sat, Mar 31, 2012 at 12:13 AM, Rohan Garg <rohan16garg at gmail.com> wrote:
> Hi
> If I understood the code correctly, in set_remote_candidates if every
> remote candidate in the list is invalid or when
> priv_add_remote_candidate returns false for every candidate, 'added'
> remains as 0 whereas the correct value should be -1 since no
> candidates were added for connchecks. I've added a patch that fixes
> this issue.
> Best
> Rohan Garg

More information about the nice mailing list