[Nice] libnice broken with glib 2.36

[Rohan Garg]

Thanks Olivier :)
Regards
Rohan Garg


On Thu, Apr 4, 2013 at 4:52 AM, Olivier Crête
<olivier.crete at collabora.com> wrote:
> Sorry for the long delay, Youness is pretty busy so I pushed your patch
> with a little change to actually require GLib 2.30 as we have no
> guarantees that it still works with older versions.
>
> Olivier
>
> On Wed, 2013-04-03 at 19:26 +0530, Rohan Garg wrote:
>> I'm guessing my last email slipped through the cracks.
>>
>> @Youness could you review the patch from my last email and apply it if
>> it's good?
>> Regards
>> Rohan Garg
>>
>>
>> On Wed, Mar 27, 2013 at 12:34 PM, Rohan Garg <rohan16garg at gmail.com> wrote:
>> > Better?
>> > Regards
>> > Rohan Garg
>> >
>> >
>> > On Tue, Mar 26, 2013 at 11:57 PM, Olivier Crête
>> > <olivier.crete at collabora.com> wrote:
>> >> On Tue, 2013-03-26 at 23:05 +0530, Rohan Garg wrote:
>> >>> Any recommendations on what GLIB_VERSION_MAX_ALLOWED should be set to?
>> >>
>> >> The version of glib required in the configure.ac (so it will warn future
>> >> devs if they had APIs that didn't exist in that version).
>> >>
>> >>> Regards
>> >>> Rohan Garg
>> >>>
>> >>>
>> >>> On Fri, Mar 22, 2013 at 9:57 PM, Olivier Crête
>> >>> <olivier.crete at collabora.com> wrote:
>> >>> > On Fri, 2013-03-22 at 11:27 +0530, Rohan Garg wrote:
>> >>> >> I did some poking around on the internet. NetworkManager passes
>> >>> >> -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_32 when compiling the code.
>> >>> >> So I stole that idea and modified configure.ac so that the appropriate
>> >>> >> flags are added when compiling.
>> >>> >> Regards
>> >>> >> Rohan Garg
>> >>> >
>> >>> > You should also add GLIB_VERSION_MAX_ALLOWED to whatever version is
>> >>> > required, so that we assert if someone tries to use more recent APIs.
>> >>> >
>> >>> > Olivier
>> >>> >
>> >>> > --
>> >>> > Olivier Crête
>> >>> > olivier.crete at collabora.com
>> >>> >
>> >>> > _______________________________________________
>> >>> > nice mailing list
>> >>> > nice at lists.freedesktop.org
>> >>> > http://lists.freedesktop.org/mailman/listinfo/nice
>> >>> _______________________________________________
>> >>> nice mailing list
>> >>> nice at lists.freedesktop.org
>> >>> http://lists.freedesktop.org/mailman/listinfo/nice
>> >>
>> >> --
>> >> Olivier Crête
>> >> olivier.crete at collabora.com
>> >>
>> >> _______________________________________________
>> >> nice mailing list
>> >> nice at lists.freedesktop.org
>> >> http://lists.freedesktop.org/mailman/listinfo/nice
>> _______________________________________________
>> nice mailing list
>> nice at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/nice
>
> --
> Olivier Crête
> olivier.crete at collabora.com
>
> _______________________________________________
> nice mailing list
> nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice