[Nice] patch for TURN nonce expired

Youness Alaoui youness.alaoui at collabora.co.uk
Wed Mar 20 12:49:55 PDT 2013

Humm.. I'm not sure this is done the right way. Shouldn't the error be validated
in the nice agent rather than stun agent, since that error is specific to turn,
right ?
I think libnice should detect that error and clear the nonce and retry, instead
of considering that the message is not authenticated.
I'll have to think about it, but I'm a bit busy now.


On 02/28/2013 05:48 AM, Madaro Livio wrote:
> Hi,
> I think there is a problem when  TURN nonce expires.
> If the nonce expires the TURN server replies with error code 438 when libnice
> sends a TURN allocation refresh.  libnice should re-send the allocation refresh
> with the new nonce but libnice fails to validate the error code 438
> Using turnserver.org the nonce expires after 1 hour.
> I send a patch for review. I just added a check for error code 438 in stun
> validation (stun_agent_validate). Do you think the check for error 438 is
> missing elsewhere?
> Regards,
> Livio
> Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone
> indicate. La diffusione, copia o qualsiasi altra azione derivante dalla
> conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate
> ricevuto questo documento per errore siete cortesemente pregati di darne
> immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie.
> /This e-mail and any attachments// is //confidential and may contain privileged
> information intended for the addressee(s) only. Dissemination, copying, printing
> or use by anybody else is unauthorised. If you are not the intended recipient,
> please delete this message and any attachments and advise the sender by return
> e-mail, Thanks./
> *rispetta l'ambienteRispetta l'ambiente. Non stampare questa mail se non è
> necessario.*
> _______________________________________________
> nice mailing list
> nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/nice/attachments/20130320/1b4c870c/attachment.pgp>

More information about the nice mailing list