[Nice] libnice broken with glib 2.36

[Rohan Garg]

I did some poking around on the internet. NetworkManager passes
-DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_32 when compiling the code.
So I stole that idea and modified configure.ac so that the appropriate
flags are added when compiling.
Regards
Rohan Garg


On Fri, Mar 22, 2013 at 6:34 AM, Rohan Garg <rohan16garg at gmail.com> wrote:
> @Olivier Thanks!!
>
> @Youness Sure, I just need a bit of time ;)
>
> Should I also remove the older ifdef's in light of this new information?
>
> Regards
> Rohan Garg
>
>
> On Fri, Mar 22, 2013 at 3:52 AM, Youness Alaoui
> <youness.alaoui at collabora.co.uk> wrote:
>> On 03/21/2013 05:20 PM, Olivier Crête wrote:
>>> On Thu, 2013-03-21 at 17:49 +0530, Rohan Garg wrote:
>>>> Hi everyone
>>>> It seems like libnice is broken again after the latest glib update to
>>>> 2.36 where GLib developers have deprecated g_type_init ( maybe even
>>>> more things, I didn't bother to go further than the first compile
>>>> error ).
>>>>
>>>> While I can add more ifdef's, this seems like a crappy solution. Any
>>>> ideas on how to proceed here?
>>>
>>> You just need to define this before including glib and you won't get the
>>> deprecating warnings.
>>>
>>> #define GLIB_VERSION_MIN_REQUIRED GLIB_VERSION_2_32
>>>
>>>
>> Oh cool, thanks Olivier, at least there's a way to avoid the deprecation :)
>> Rohan, could you test with that, and make sure it's defined everywhere glib is
>> included and test, then send me a patch so I can push it upstream?
>> Thanks!
>>
>>
>> _______________________________________________
>> nice mailing list
>> nice at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/nice
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Set-the-minimum-GLib-version-to-2.32-to-disable-depr.patch
Type: application/octet-stream
Size: 840 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/nice/attachments/20130322/6462249b/attachment.obj>