<html><head></head><body><div>Hi,</div><div><br></div><div>That is really interesting,</div><div><br></div><div>On Mon, 2017-04-10 at 18:42 +0200, Lorenzo Miniero wrote:</div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2017-02-27 22:30 GMT+01:00 Chad Phillips <span dir="ltr"><<a href="mailto:chad@apartmentlines.com" target="_blank">chad@apartmentlines.com</a>></span>:<br><blockquote type="cite"><div dir="ltr"><p>Some git bisect work got me to the problem commit:</p> <p>1ab9d7c104978ea1904aaaad708c1c<wbr>8c23c77592 is the first bad commit<br> commit 1ab9d7c104978ea1904aaaad708c1c<wbr>8c23c77592</p></div></blockquote></div></div></div></blockquote><div><br></div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote type="cite"><div dir="ltr"><p>conncheck: Separate valid and succeded states</p></div></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"></div></div></div></blockquote><div><br></div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>He then tried a patch another user referenced on our issue page, and it worked instead: <a href="https://phabricator.freedesktop.org/D735">https://phabricator.freedesktop.org/D735</a></div></div></div></div></blockquote><div><br></div><div>I've been looking at this patch a couple times and the reason I didn't merge it is that I don't understand what it tries to accomplish.</div><div><br></div><div>But now I think I figured it out. It seems that libnice sets the "nominated" flag on all the pairs when it creates them as a controlling agent, which seems wrong. I think it should set the flag only when it gets a reply... And this is why propagating the flag fixes it in some cases, but I think we need to go over the whole conncheck code and make it set the nominated flag at the right time (after the reply is received!).</div><div><br></div><div><span><pre><pre>-- <br></pre>Olivier Crête olivier.crete@collabora.com </pre></span></div></body></html>