[Nouveau] [RFC] patch 0/4: DRM MMIO accessor cleanup
Pekka Paalanen
pq at iki.fi
Sat Jul 25 05:29:03 PDT 2009
Hi,
this is continuation for the MMIO accessor rewrite and cleanup.
I am currently running nv28 with these patches applied, but
I cannot test on PPC.
Please, review and comment. If the direction is good, I'll do the
same to INSTANCE_{RD,WR} as I did for nv_{rd,wr}32, and change
PRAMIN from drm_local_map to simple ioremap.
Can the same be done for channel specific mappings, that is
nvchan_{rd,wr}32?
The macros nv_{in,out}32 are very close to removal now.
It also looks like nouveau_load() is in need of serious error
path review for resource leakage. And maybe refactorization,
too, into small functions.
- pq
More information about the Nouveau
mailing list