[Nouveau] [Bug 15792] nv04 (TNT2) video blitter problem.

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=15792





--- Comment #12 from Stuart Bennett <sb476 at cam.ac.uk>  2009-03-06 06:53:33 PST ---
(In reply to comment #11)
> Ok, indeed it seems we can't catch the failing allocation itself. But still,
> doing:
> if (exaGetPixmapOffset(ppix) >= pNv->FB->size)
> totally assumes that the FB is at the beggining of the EXA area. We've done
> such asumptions before and they always break in the end. Is there no other way
> ?
> If all else fails, at least make it check agains FB->size and FB->offset.

As I understand it pNv->FB includes the entire EXA area, not just the visible
fb, exaGetPixmapOffset returns an offset relative to pExaScr->info->memoryBase
(set to pNv->FB->map in nouveau_exa.c), so to see if a pixmap is in VRAM isn't
testing if the (unsigned) offset is bigger than pNv->FB->size [*] correct,
regardless of the positioning of the visible fb?

[*] or equivalently pNv->EXADriverPtr->memorySize which is perhaps more robust
to changes in nouveau


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.