[Nouveau] NVPutBlitImage has incorrect return type -- should be int, not Bool

Reece Dunn msclrhd at googlemail.com
Sun Nov 29 14:23:48 PST 2009


Hi,

Looking at http://cgit.freedesktop.org/nouveau/xf86-video-nouveau/commit/?id=5315034b7d46980a3527c814526857aed3bc98f7,
NVPutBlitImage was changed from a void return type to Bool return
type.

However, the return values are BadImplementation and Success, not TRUE
and FALSE. Therefore, the return type should not be Bool.

- Reece


More information about the Nouveau mailing list