[Nouveau] [PATCH] drm/nouveau/kms: Implement KDB debug hooks for nouveau KMS.

[Francisco Jerez]

Chris Ball <cjb at laptop.org> writes:

> Hi,
>
> Here's a patch to add support for KMS debugging to Nouveau, along the
> style of the previous patches for Intel¹ and Radeon².  I'm only able
> to test on nv50 here, so a test on nv04 would be much appreciated,
> and I've published instructions on how to test here³.  Thanks!
>
There is a problem with this on pre-nv20 cards. Fbcon acceleration won't
work properly with IRQs disabled because you miss the context switching
interrupts: You'll get a locked up fbcon if you hit sysrq-g when there's
some process using the GPU.

I'd suggest disabling acceleration while in debug mode (e.g. using
nouveau_fbcon_save_disable_accel()). That aside the patch looks good to
me.

> - Chris.
>
> ¹:  http://lkml.org/lkml/2010/8/5/280
> ²:  http://dev.laptop.org/~cjb/kdb-radeon.patch
> ³:  http://blog.printf.net/articles/2010/08/19/kdb-kms-for-nouveau-radeon
>
>
> [...]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/nouveau/attachments/20100821/c4df3deb/attachment.pgp>