[Nouveau] [PATCH] drm/nouveau: don't hold spin lock while calling kzalloc with GFP_KERNEL

Marcin Slusarz marcin.slusarz at gmail.com
Sun Feb 7 01:54:04 PST 2010

On Sun, Feb 07, 2010 at 02:11:20AM +0100, Maarten Maathuis wrote:
> - 'joi' on irc pointed out that this triggers a BUG_ON, because kzalloc could
> sleep.
> - The irq handler should restore the value NV03_PFIFO_CACHES, but still it's
> better if this stuff doesn't happen in the middle of fifo create context. I see
> no reason in spin locking pgraph create context, it isn't activated at that
> stage.
> - Move and rename the lock after some discussion with 'joi', even better naming
> suggestions are appreciated.
> Signed-off-by: Maarten Maathuis <madman2003 at gmail.com>


Tested-by: Marcin Slusarz <marcin.slusarz at gmail.com>

More information about the Nouveau mailing list