[Nouveau] [Mesa3d-dev] [PATCH 2/2] st: don't assert on empty fragment program

Brian Paul brianp at vmware.com
Mon Jan 18 10:26:14 PST 2010


Luca Barbieri wrote:
> Breakpoint 3, _mesa_ProgramStringARB (target=34820, format=34933,
> len=70, string=0x85922ba) at shader/arbprogram.c:434
> 434	   GET_CURRENT_CONTEXT(ctx);
> $31 = 0x85922ba "!!ARBfp1.0\n    \n    OPTION
> ARB_precision_hint_fastest;\n    \n\n\n    END\n"
> 
> Not sure why Sauerbraten does this, but it does, at least on my system
> (Ubuntu Karmic, nv40 driver) and it should be legal.

OK, GL_ARB_fragment_programs says a fragment program does not have to 
write a color result (so the color is undefined).

But the assertion should be changed to "num instructions > 0" and not 
removed.  I'll fix that.

-Brian



More information about the Nouveau mailing list