[Nouveau] [PATCH] renouveau/nv10: remove duplicate vertex buffer registers

Francisco Jerez currojerez at riseup.net
Mon Mar 1 13:42:18 PST 2010


Luca Barbieri <luca at luca-barbieri.com> writes:

> On Mon, Mar 1, 2010 at 2:34 AM, Francisco Jerez <currojerez at riseup.net> wrote:
>> Luca Barbieri <luca at luca-barbieri.com> writes:
>>
>>> NV10TCL defines the vertex buffer registers both as arrays and as
>>> individual named registers.
>>>
>>> This causes duplicate register definitions and the individual registers
>>> are not used either by the DDX or by the Mesa driver.
>>>
>>> Francisco Jerez said to remove them all.
>>>
>> I forgot to ask: why do they bother you?
>
> I am experimenting with rewriting renouveau-gen.c in Python, and
> stored registers in a dictionary with the register offset as key.
>
> Having multiple registers at the same offset obviously causes issues
> with that, and this is the only instance of that problem, so it seems
> better to remove it than adding complexity to tools to handle it.

Fair enough, commited.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/nouveau/attachments/20100301/4e42df6e/attachment.pgp>


More information about the Nouveau mailing list