[Nouveau] [Mesa3d-dev] makedepend in Mesa

[Dan Nicholson]

On Fri, Mar 19, 2010 at 12:23 PM, Xavier Chantry
<chantry.xavier at gmail.com> wrote:
> On Thu, Feb 25, 2010 at 9:41 PM, Dan Nicholson <dbn.lists at gmail.com> wrote:
>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 485836a..a582337 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -28,8 +28,11 @@ AC_PROG_CPP
>>>  AC_PROG_CC
>>>  AC_PROG_CXX
>>>  AC_CHECK_PROGS([MAKE], [gmake make])
>>> -AC_PATH_PROG([MKDEP], [makedepend])
>>>  AC_PATH_PROG([SED], [sed])
>>> +AC_PATH_PROG([MKDEP], [makedepend], no)
>>> +if test "x$MKDEP" = xno; then
>>> +    AC_MSG_ERROR([makedepend not found])
>>> +fi
>>
>> Yep, that would do it. In fact, when I wrote configure.ac originally,
>> I wanted it to be a hard requirement and assumed that AC_PATH_PROG
>> would error by default if it didn't find the program.
>>
>
> Should I resubmit a proper git patch ?

Sure.

> I have been running with makedepend installed on my 3 systems for 1
> month, it has worked very well. I don't think I got ONE weird failure
> in the past month, while I used to get more than once per week.
> The only thing I need is to sometimes run autogen.sh and/or configure,
> when there are some structure changes (e.g. nv30-nv40 merge to nvfx).
> AFAIK this is also handled automatically in other projects. But this
> is much less annoying, because it fails at build time, instead of
> segfaulting at runtime.

Yeah, automatic autotools updates could maybe be handled in the
top-level Makefile, but really that's more of a job that automake
takes care of.

> Everyone complains about mesa crappy build system so I thought all the
> failures I got were expected. Now I see they weren't, just that
> makedepend is badly required :)
>
> I am just worried some people might run into the same troubles as me.
> But I wonder if there are any since only Dan answered in that thread.

The only drawback I know of is adding a hard requirement on makedepend
where there wasn't one before, but distros usually have it.

--
Dan