[Nouveau] [Bug 33434] [nouveau nv84] BUG while reloading module

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Jan 29 14:31:11 PST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=33434

--- Comment #3 from Xavier <shiningxc at gmail.com> 2011-01-29 14:31:11 PST ---
looks like thats the culprit :

commit 3d58ec154bc87b206a3439f064e1c8aa6090c1ee
Author: Lucas Stach <dev at lynxeye.de>
Date:   Thu Jan 6 20:29:53 2011 +0100

    drm/nouveau: fix hwmon device binding

    Bind the hwmon structs to nouveau device kobj. This makes sure
    the hwmon files are created in the device subdir in line with
    all other hwmon drivers.

    Signed-off-by: Lucas Stach <dev at lynxeye.de>
    Signed-off-by: Ben Skeggs <bskeggs at redhat.com>

diff --git a/drivers/gpu/drm/nouveau/nouveau_pm.c
b/drivers/gpu/drm/nouveau/nouveau_pm.c
index d938141..fb846a3 100644
--- a/drivers/gpu/drm/nouveau/nouveau_pm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_pm.c
@@ -422,8 +422,7 @@ nouveau_hwmon_init(struct drm_device *dev)
                return ret;
        }
        dev_set_drvdata(hwmon_dev, dev);
-       ret = sysfs_create_group(&hwmon_dev->kobj,
-                                       &hwmon_attrgroup);
+       ret = sysfs_create_group(&dev->pdev->dev.kobj, &hwmon_attrgroup);
        if (ret) {
                NV_ERROR(dev,
                        "Unable to create hwmon sysfs file: %d\n", ret);

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Nouveau mailing list