[Nouveau] [Mesa-dev] [PATCH v2 2/2] xorg/nouveau: blacklist all pre NV30 cards

[Maarten Maathuis]

On Sun, Jun 5, 2011 at 9:46 PM, Marcin Slusarz <marcin.slusarz at gmail.com> wrote:
> On Sun, Jun 05, 2011 at 09:15:47PM +0200, Maarten Maathuis wrote:
>> 2011/6/5 Stéphane Marchesin <stephane.marchesin at gmail.com>:
>> > On Sun, Jun 5, 2011 at 12:06, Marcin Slusarz <marcin.slusarz at gmail.com> wrote:
>> >> On Tue, May 17, 2011 at 12:20:14AM +0200, Marcin Slusarz wrote:
>> >>> Bail out early in probe, so other driver can take control of the card.
>> >>> Doing it in screen_create would be too late.
>> >>> ---
>> >>>  src/gallium/targets/xorg-nouveau/nouveau_xorg.c |   44 ++++++++++++++++++-----
>> >>>  1 files changed, 35 insertions(+), 9 deletions(-)
>> >>
>> >> ping
>> >>
>> >
>> > Why do you need a list of cards for that, as opposed to reading the reg?
>> >
>>
>> I agree with Stephane, checking register 0 should work fine. First
>> check for NV04/05, then for NV10-NV2F.
>>
>
> I did it this way because I didn't have access to device file descriptor - it's created
> somewhere near InitScreen and passed to nouveau_drm_screen_create - too late to
> exit gracefully (something which I believe is a bug, but I couldn't track it).
>
> But now I see xf86-video-nouveau is in exactly the same situation - it opens fd
> temporarily in PciProbe. I'll adapt its code to target/xorg-nouveau.

I was incorrect in saying that you should check registers yourself
(which would require root), but opening the device should give you the
chipset type.

>
> Marcin
>



-- 
Far away from the primal instinct, the song seems to fade away, the
river get wider between your thoughts and the things we do and say.