[Nouveau] [PATCH] drm/nouveau: fix acpi related kbuild warnings

Marcin Slusarz marcin.slusarz at gmail.com
Wed Nov 9 13:32:34 PST 2011


On Wed, Nov 02, 2011 at 10:39:40PM +0100, Marcin Slusarz wrote:
> Currently when X86 && ACPI && !X86_PLATFORM_DEVICES kbuild spits:
> 
> warning: (DRM_NOUVEAU) selects ACPI_WMI which has unmet direct
> dependencies (X86 && X86_PLATFORM_DEVICES && ACPI)
> warning: (DRM_NOUVEAU) selects MXM_WMI which has unmet direct
> dependencies (X86 && X86_PLATFORM_DEVICES && ACPI_WMI)
> 
> and goes on, which leaves a situation where ACPI_WMI (which depends on
> X86_PLATFORM_DEVICES) is enabled but X86_PLATFORM_DEVICES is not.
> Additionally, Nouveau on IA64 would enable these X86-related drivers
> when ACPI is enabled (doesn't matter but is wrong) and build
> nouveau_acpi.c which depends on them.
> 
> To fix this, introduce hidden DRM_NOUVEAU_ACPI variable which selects
> all acpi/x86 related configs and select it when both X86 and ACPI are
> enabled.
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz at gmail.com>
> ---

Ben, can you apply it to Nouveau tree?

Thanks,
Marcin


More information about the Nouveau mailing list