[Nouveau] [PATCH 08/10] drm: debugfs: remove debug directores using recursion.

Maxim Levitsky maximlevitsky at gmail.com
Sun Oct 9 13:58:38 PDT 2011


Well, I implemented a custom debugfs file for nouveau,
but found it hard to remove it cleanly due to constrains on drm debugfs api.
I implemented a hack and then surprised that other drivers (intel and radeon) have exactly same ugly hack.
So why? Just one liner does the job.
This patch shouldn't break other driver, and with it, some code (the hacks) can be removed from them now.

Signed-off-by: Maxim Levitsky <maximlevitsky at gmail.com>
---
 drivers/gpu/drm/drm_debugfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index 9d2668a..4a859a9 100644
--- a/drivers/gpu/drm/drm_debugfs.c
+++ b/drivers/gpu/drm/drm_debugfs.c
@@ -228,7 +228,7 @@ int drm_debugfs_cleanup(struct drm_minor *minor)
 
 	drm_debugfs_remove_files(drm_debugfs_list, DRM_DEBUGFS_ENTRIES, minor);
 
-	debugfs_remove(minor->debugfs_root);
+	debugfs_remove_recursive(minor->debugfs_root);
 	minor->debugfs_root = NULL;
 
 	return 0;
-- 
1.7.4.1



More information about the Nouveau mailing list