[Nouveau] [PATCH] drm/nouveau/clk: fix crystal frequency retrieval on nv25

Viktor Novotný noviktor at seznam.cz
Sat Nov 10 10:24:06 PST 2012


Signed-off-by: Viktor Novotný <noviktor at seznam.cz>
---
Hi,

this fixes a regression I have seen since the kernel module rewrite in summer. After loading nouveau, screen would go 
all black and monitor would show "Out of range". According to envytools' hwdocs/pstraps.txt nv25 should use both pstraps
bits(6 & 22) so I hope this fix is valid for all nv25 cards, not just mine.

Best regards
Viktor
 
 drivers/gpu/drm/nouveau/core/subdev/device/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/core/subdev/device/base.c b/drivers/gpu/drm/nouveau/core/subdev/device/base.c
index ca9a464..9baef46 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/device/base.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/device/base.c
@@ -208,7 +208,7 @@ nouveau_devobj_ctor(struct nouveau_object *parent,
 
 		/* determine frequency of timing crystal */
 		if ( device->chipset < 0x17 ||
-		    (device->chipset >= 0x20 && device->chipset <= 0x25))
+		    (device->chipset >= 0x20 && device->chipset < 0x25))
 			strap &= 0x00000040;
 		else
 			strap &= 0x00400040;
-- 
1.8.0



More information about the Nouveau mailing list