[Nouveau] [PATCH] drm/nouveau: comment out unused _nouveau_parent_ctor

Ben Skeggs skeggsb at gmail.com
Sun Oct 7 18:07:34 PDT 2012


On Mon, Oct 08, 2012 at 12:49:28AM +0200, Marcin Slusarz wrote:
> Signed-off-by: Marcin Slusarz <marcin.slusarz at gmail.com>
> ---
>  drivers/gpu/drm/nouveau/core/core/parent.c         | 2 ++
>  drivers/gpu/drm/nouveau/core/include/core/parent.h | 3 +++
>  2 files changed, 5 insertions(+)
Feel free to just kill it completely.  There's a few bits and pieces
of left-overs like this around the place, I'll be killing them as
I run across them too.

What do you think?

Ben.

> 
> diff --git a/drivers/gpu/drm/nouveau/core/core/parent.c b/drivers/gpu/drm/nouveau/core/core/parent.c
> index a1ea034..0e7733c 100644
> --- a/drivers/gpu/drm/nouveau/core/core/parent.c
> +++ b/drivers/gpu/drm/nouveau/core/core/parent.c
> @@ -101,6 +101,7 @@ nouveau_parent_create_(struct nouveau_object *parent,
>  	return 0;
>  }
>  
> +#if 0
>  int
>  _nouveau_parent_ctor(struct nouveau_object *parent,
>  		     struct nouveau_object *engine,
> @@ -117,6 +118,7 @@ _nouveau_parent_ctor(struct nouveau_object *parent,
>  
>  	return 0;
>  }
> +#endif
>  
>  void
>  nouveau_parent_destroy(struct nouveau_parent *parent)
> diff --git a/drivers/gpu/drm/nouveau/core/include/core/parent.h b/drivers/gpu/drm/nouveau/core/include/core/parent.h
> index d3aa251..58bf6b5 100644
> --- a/drivers/gpu/drm/nouveau/core/include/core/parent.h
> +++ b/drivers/gpu/drm/nouveau/core/include/core/parent.h
> @@ -50,9 +50,12 @@ int  nouveau_parent_create_(struct nouveau_object *, struct nouveau_object *,
>  			    int size, void **);
>  void nouveau_parent_destroy(struct nouveau_parent *);
>  
> +#if 0
>  int  _nouveau_parent_ctor(struct nouveau_object *, struct nouveau_object *,
>  			  struct nouveau_oclass *, void *, u32,
>  			  struct nouveau_object **);
> +#endif
> +
>  void _nouveau_parent_dtor(struct nouveau_object *);
>  #define _nouveau_parent_init _nouveau_object_init
>  #define _nouveau_parent_fini _nouveau_object_fini
> -- 
> 1.7.12
> 
> _______________________________________________
> Nouveau mailing list
> Nouveau at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau


More information about the Nouveau mailing list