[Nouveau] [PATCH] drm/nouveau: remove >1 sclass support from nouveau_parent_create_

Ben Skeggs skeggsb at gmail.com
Mon Oct 8 17:05:54 PDT 2012


On Tue, Oct 09, 2012 at 01:02:08AM +0200, Marcin Slusarz wrote:
> On Mon, Oct 08, 2012 at 11:06:46AM +1000, Ben Skeggs wrote:
> > On Mon, Oct 08, 2012 at 12:49:30AM +0200, Marcin Slusarz wrote:
> > > It's unused (only one codepath passes sclass at all and it's always one),
> > > broken (overwrites the same field, leaking previous one) and confusing.
> > It's only *currently* unused, I have WIP code in branches that uses it,
> > otherwise it wouldn't still exist :)
> 
> Yeah, like _nouveau_parent_ctor :P
Point taken :P

> 
> > I will take a look today at the claims it's broken, it wasn't at some
> > point but may have got busted along the way somehow.
> 
> Oh, it chains them in list...
> 
> /me hides.
Hehe :)

Ben.

> 
> Marcin


More information about the Nouveau mailing list