[Nouveau] Fwd: [PATCH] nouveau: Fix unconditional return waiting on memory

Calvin Owens jcalvinowens at gmail.com
Sun Apr 7 19:01:19 PDT 2013


----- Forwarded message from Calvin Owens <jcalvinowens at gmail.com> -----

From: Calvin Owens <jcalvinowens at gmail.com>
To: dri-devel at lists.freedesktop.org, linux-kernel at vger.kernel.org
CC: Ben Skeggs <bskeggs at redhat.com>, Calvin Owens <jcalvinowens at gmail.com>
Date: Thu, 21 Mar 2013 13:10:12 -0500
Subject: [PATCH] nouveau: Fix unconditional return waiting on memory

Typo in nv50_display_flip_wait allows page flipping to run ahead before
memory has time to settle.

Signed-off-by: Calvin Owens <jcalvinowens at gmail.com>
---
 drivers/gpu/drm/nouveau/nv50_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
index 2db5799..96bc2f3 100644
--- a/drivers/gpu/drm/nouveau/nv50_display.c
+++ b/drivers/gpu/drm/nouveau/nv50_display.c
@@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
 {
 	struct nv50_display_flip *flip = data;
 	if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
-					      flip->chan->data);
+					      flip->chan->data)
 		return true;
 	usleep_range(1, 2);
 	return false;
-- 
1.7.3.4

----- End forwarded message -----


More information about the Nouveau mailing list