[Nouveau] [PATCH] drm/nouveau: force alignment to 0x1000 for gpu objects

Maarten Lankhorst maarten.lankhorst at canonical.com
Wed Sep 4 04:59:17 PDT 2013


Op 04-09-13 05:34, Ben Skeggs schreef:
> On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst
> <maarten.lankhorst at canonical.com> wrote:
>> There are a lot of places that allocate multiples of 1000,
>> but do not set alignment correctly and still require this
>> alignment implicitly or explicitly.
> This is wrong.  Where are the places you think you need this?
>
All the calls to nouveau_gpuobj_map_vm for example in core/engine/graph/nvc0.c.

engctx_create is usually called with alignment = 0x100 too, which seems like it would break in the fifo_context_attach calls too.

~Maarten


More information about the Nouveau mailing list