[Nouveau] [RESEND PATCH nouveau 2/3] volt: allow non-bios voltage scaling

Martin Peres martin.peres at free.fr
Mon Dec 1 14:57:39 PST 2014


On 29/11/2014 09:22, Alexandre Courbot wrote:
> On Fri, Nov 28, 2014 at 8:12 PM, Vince Hsu <vinceh at nvidia.com> wrote:
>> Signed-off-by: Vince Hsu <vinceh at nvidia.com>
> Make sure you always write a short summary for your patches, even if
> the title sounds sufficient.

I agree. Something like "Move the vbios parsing out of init() and
call it conditionally if the platform has a vbios. Non-vbios platforms
can use the ctor() to init the data structures.".

> At the very least this patch makes the code easier to read, so:
>
> Acked-by: Alexandre Courbot <acourbot at nvidia.com>
Acked-by: Martin Peres <martin.peres at free.fr>


More information about the Nouveau mailing list