[Nouveau] [PATCH 1/6] platform: specify the IOMMU physical translation bit

Vince Hsu vinceh at nvidia.com
Thu Apr 16 19:22:40 PDT 2015



On 04/17/2015 04:41 AM, Terje Bergstrom wrote:
>
> On 04/16/2015 04:06 AM, Vince Hsu wrote:
>> diff --git a/drm/nouveau/nouveau_platform.h 
>> b/drm/nouveau/nouveau_platform.h
>> index 392874cf4725..3e9bd7dc0092 100644
>> --- a/drm/nouveau/nouveau_platform.h
>> +++ b/drm/nouveau/nouveau_platform.h
>> @@ -53,6 +53,7 @@ struct nouveau_platform_gpu {
>>           struct nvkm_mm *mm;
>>           struct iommu_domain *domain;
>>           unsigned long pgshift;
>> +        unsigned long phys_addr_bit;
>>       } iommu;
>>   };
> The naming is a bit reversed - the bit set tells we use SMMU, and bit 
> cleared tells we use physical addressing. So the name of the bit 
> should be iommu_addr_bit.
Yep, you're right. How about just "addr_bit" because we already have the 
struct name iommu as prefix.

Thanks,
Vince



-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------


More information about the Nouveau mailing list