[Nouveau] [PATCH 2/6] instmem/gk20a: refer to IOMMU physical translation bit

Terje Bergstrom tbergstrom at nvidia.com
Fri Apr 17 08:14:20 PDT 2015


On 04/16/2015 11:26 PM, Alexandre Courbot wrote:
> Looks good, but I think I would definitely prefer this to be a mask
> instead of a bit index, i.e:
>
>      r->offset &= ~(priv->iommu_addr_mask >> priv->iommu_pgshift);
>
> and
>
>      r->offset |= (priv->iommu_addr_mask >> priv->iommu_pgshift);
Wouldn't that be just a more complicated way of expressing the same thing?


More information about the Nouveau mailing list