[Nouveau] [PATCH 1/2] nouveau: make nouveau importing global buffers completely thread-safe, with tests

[Emil Velikov]

On 25 February 2015 at 21:59, Maarten Lankhorst
<maarten.lankhorst at canonical.com> wrote:
> On 25-02-15 15:14, Emil Velikov wrote:
>> On 24 February 2015 at 09:01, Maarten Lankhorst
>> <maarten.lankhorst at ubuntu.com> wrote:
...
>>> +static const char default_device[] = "/dev/dri/renderD128";
>>> +
>> Reuse the defines in xf86drm.h ?
>
> Hmm, switching to drmOpenWithType("nouveau", NULL, DRM_NODE_RENDER) might be better..
>
I saw that patch floating on the list, but did not know it landed already. Nice

...
>>> -# define atomic_dec_and_test(x) (__sync_fetch_and_add (&(x)->atomic, -1) == 1)
>>> +# define atomic_inc_return(x) (__sync_add_and_fetch (&(x)->atomic, 1))
>>> +# define atomic_dec_and_test(x) (__sync_add_and_fetch (&(x)->atomic, -1) == 0)
>> The atomic_dec_and_test change seems like unrelated bugfix. Split it
>> out perhaps ?
> Not a bug fix, just swapping the order..
> - atomic_fetch_and_add(-1) == 1
> + atomic_add_and_fetch(-1) == 0
>
Oops, I'm blind.

...
>> IMHO sending the series for dri-devel might be nice, for at least the
>> xf86atomic.h changes.
> Probably, not sure anyone will review it though, so I think just adding in a separate commit is fine.
>
If they don't then it's their problem. At least you've done the right thing :-)

Thanks
Emil