[Nouveau] [Mesa-dev] [RFC PATCH 5/8] nv50: prevent NULL pointer dereference with pipe_query functions

Samuel Pitoiset samuel.pitoiset at gmail.com
Tue Jun 23 00:28:50 PDT 2015



On 06/23/2015 08:57 AM, Michel Dänzer wrote:
> On 23.06.2015 06:02, Samuel Pitoiset wrote:
>>
>> On 06/22/2015 10:52 PM, Ilia Mirkin wrote:
>>> If query_create fails, why would any of these functions get called?
>> Because the HUD doesn't check if query_create() fails and it calls other
>> pipe_query functions with NULL pointer instead of a valid query object.
> Could the HUD code be fixed instead?
It's definitely possible, and probably the best solution instead of 
preventing NULL pointer dereference in the underlying drivers. I'll make 
a patch.
>
>



More information about the Nouveau mailing list