[Nouveau] [PATCH] instmem/gk20a: exclusively acquire instobjs

Alexandre Courbot gnurou at gmail.com
Sun Nov 8 22:26:12 PST 2015


On Thu, Nov 5, 2015 at 3:44 PM, Alexandre Courbot <gnurou at gmail.com> wrote:
> On Thu, Nov 5, 2015 at 6:19 AM, Ben Skeggs <skeggsb at gmail.com> wrote:
>> On 10/26/2015 03:54 PM, Alexandre Courbot wrote:
>>> Although I would not have expected this to happen, we seem to run into
>>> race conditions if instobjs are accessed concurrently. Use a global lock
>>> for safety.
>> I wouldn't expect this to be an issue either.
>>
>> Before merging such a large hammer of a fix, I'd strongly prefer to see
>> at least a better justification for why this is happening rather than
>> potentially papering over a larger issue.
>
> I was afraid you would say that. ;)
>
> But you're right. I am really busy with lots of stuff but will try to
> rootcause this more precisely...

Turns out this was just me not knowing how to handle concurrency properly. >_<

Fortunately this means that the error was just confined to the gk20a
implementation and is not part of something larger. I will send the
correct fixup patch later today.

Thanks for refusing my lazy hacks! :)


More information about the Nouveau mailing list