[Nouveau] [PATCH 1/2] nouveau: arm: Add MODULE_FIRMWARE for gk20a

[Alexandre Courbot]

On Sat, Sep 19, 2015 at 3:17 AM, Ben Skeggs <skeggsb at gmail.com> wrote:
> On 19 September 2015 at 01:52, Alexandre Courbot <gnurou at gmail.com> wrote:
>> On Wed, Sep 9, 2015 at 11:04 PM, Nicolas Chauvet <kwizart at gmail.com> wrote:
>>> This patch is needed by initramfs tools to detect
>>> the required firmware files for the module.
>>>
>>> This patch tests for NOUVEAU_PLATFORM_DRIVER and either
>>> TEGRA_124_SOC or TEGRA_132_SOC for the firmwares related to
>>> the Tegra K1 generation.
>>
>> I think you should send this to the Nouveau tree, especially since the
>> kernel tree probably predates the big refactoring that Nouveau has
>> undergone.
>>
>> I also wonder whether these MODULE_FIRMWARE() statements could not be
>> placed in a more appropriate place, like nouveau_platform.c? This
>> would allow you to get rid of the test for
>> CONFIG_NOUVEAU_PLATFORM_DRIVER.
> Is there any need to be conditional at all?  For dGPUs we're going to
> have to have them all unconditional anyway, as we have know way of
> knowing which GPU it's going to be used with.

For dGPU there is indeed probably no use to make it conditional. But
do we really want to include the Tegra-specific firmwares on x86
initramsfs?