[Nouveau] [PATCH v2 07/22] volt: add min_id parameter to nvkm_volt_set_id

Martin Peres martin.peres at free.fr
Mon Mar 28 21:41:47 UTC 2016


On 28/03/16 23:52, Martin Peres wrote:
> On 21/03/16 18:16, Karol Herbst wrote:
>> min_id indicates a volt map entry which acts as a floor value, this will be
>> used to set the lower voltage limit through pstates

Please state that this comes that this min_id is different for each 
pstate, hence why volt should not know about this and needs to take it 
as an input!

>>
>> Signed-off-by: Karol Herbst <nouveau at karolherbst.de>
> Do we really want to push reclocking logic to the volt subsystem?
>
> To me, volt should just allow you to read back and set a voltage. All
> the rest of the logic should be in clk.
>
> Since this is my first NAK, here are my R-b for 3, 4 and 5:
>
> Reviewed-by: Martin Peres <martin.peres at free.fr>

With this fixed, this patch is Reviewed-by: Martin Peres 
<martin.peres at free.fr>


More information about the Nouveau mailing list