[Nouveau] [bug report] drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream

Dan Carpenter dan.carpenter at oracle.com
Wed Nov 16 11:29:59 UTC 2016


Hello Ben Skeggs,

The patch f479c0ba4a17: "drm/nouveau/kms/nv50: initial support for DP
1.2 multi-stream" from Nov 4, 2016, leads to the following static
checker warning:

	drivers/gpu/drm/nouveau/nv50_display.c:3158 nv50_mstc_new()
	warn: this array is probably non-NULL. 'mstm->msto'

drivers/gpu/drm/nouveau/nv50_display.c
  3155          mstc->connector.funcs->reset(&mstc->connector);
  3156          nouveau_conn_attach_properties(&mstc->connector);
  3157  
  3158          for (i = 0; i < ARRAY_SIZE(mstm->msto) && mstm->msto; i++)
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This doesn't make sense.  Maybe mstm->msto[i] was intended??

  3159                  drm_mode_connector_attach_encoder(&mstc->connector, &mstm->msto[i]->encoder);
  3160  
  3161          drm_object_attach_property(&mstc->connector.base, dev->mode_config.path_property, 0);
  3162          drm_object_attach_property(&mstc->connector.base, dev->mode_config.tile_property, 0);
  3163          drm_mode_connector_set_path_property(&mstc->connector, path);
  3164          return 0;

regards,
dan carpenter


More information about the Nouveau mailing list