[Nouveau] [PATCH 2/3] subdev/iccsense: Parse max and crit power level

Karol Herbst karolherbst at gmail.com
Tue Oct 25 06:06:35 UTC 2016

On 25 October 2016 7:28:10 a.m. GMT+02:00, Martin Peres <martin.peres at free.fr> wrote:
>On 25/10/16 00:11, Karol Herbst wrote:
>> Signed-off-by: Karol Herbst <karolherbst at gmail.com>
>> ---
>>  drm/nouveau/include/nvkm/subdev/iccsense.h |  3 +++
>>  drm/nouveau/nvkm/subdev/iccsense/base.c    | 13 ++++++++++++-
>>  2 files changed, 15 insertions(+), 1 deletion(-)
>What is the point of duplicating values here? Just store the parsed
>table, like we do for fan management.

will have a look. I was just thinking that thise fields may mean something else depending on the context. There are already some weird things, like we only get one value for very short entries.

But I guess it makes sense to keep it simple for now.

More information about the Nouveau mailing list