[Nouveau] [PATCH 0/5] GPU-DRM-nouveau: Fine-tuning for five function implementations
Roy Spliet
nouveau at spliet.org
Wed Sep 21 08:09:50 UTC 2016
Thanks for these style fixes. Patches 1 and 2 seem good at first sight.
Not acking because I haven't tested the patches and the implementation
of kmalloc_array() appears to slightly differ from kmalloc(). This
difference *should* only affect allocations larger than the ones in
patch 1 and 2, but I'd like to see these changes tested before I can
sleep soundly!
Patches 4 and 5 are:
Reviewed-by: Roy Spliet <nouveau at spliet.org>
Op 21-09-16 om 08:23 schreef SF Markus Elfring:
> From: Markus Elfring<elfring at users.sourceforge.net>
> Date: Wed, 21 Sep 2016 09:09:09 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (5):
> Use kmalloc_array() in nvbios_iccsense_parse()
> Use kmalloc_array() in gt215_link_train()
> Delete unnecessary braces
> Adjust a kzalloc() call in gt215_ram_new()
> Add space after an "if"
>
> drivers/gpu/drm/nouveau/nvkm/subdev/bios/iccsense.c | 4 +++-
> drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 21 +++++++++------------
> 2 files changed, 12 insertions(+), 13 deletions(-)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20160921/e09f3c42/attachment-0001.html>
More information about the Nouveau
mailing list