[Nouveau] [PATCH 3/5] GPU-DRM-nouveau: Delete unnecessary braces

[Roy Spliet]

Comments in-line. Thanks.

Roy

Op 21-09-16 om 08:26 schreef SF Markus Elfring:
> From: Markus Elfring <elfring at users.sourceforge.net>
> Date: Wed, 21 Sep 2016 08:28:08 +0200
>
> Do not use curly brackets at four source code places
> where a single statement should be sufficient.
>
> Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
> ---
>   drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 14 +++++---------
>   1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
> index dbaf577..cb50539 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
> @@ -127,12 +127,11 @@ gt215_link_train_calc(u32 *vals, struct gt215_ltrain *train)
>   	}
>   
>   	/* Find the best value for 0x1111e0 */
> -	for (i = 0; i < 4; i++) {
> +	for (i = 0; i < 4; i++)
>   		if (bins[i] > qty) {
>   			bin = i + 3;
>   			qty = bins[i];
>   		}
> -	}
I'm not a fan of removing the braces around a multi-line statement, 
despite being functionally correct. It obscures the program structure on 
displays with a low effective vertical resolution.
>   
>   	train->r_100720 = 0;
>   	for (i = 0; i < 8; i++) {
> @@ -729,9 +728,8 @@ gt215_ram_calc(struct nvkm_ram *base, u32 freq)
>   		ram_mask(fuc, 0x1007e0, 0x22222222, r100760);
>   	}
>   
> -	if (device->chipset == 0xa3 && freq > 500000) {
> +	if (device->chipset == 0xa3 && freq > 500000)
>   		ram_mask(fuc, 0x100700, 0x00000006, 0x00000000);
> -	}
>   
>   	/* Final switch */
>   	if (mclk.pll) {
> @@ -745,12 +743,11 @@ gt215_ram_calc(struct nvkm_ram *base, u32 freq)
>   	ram_nsec(fuc, 2000);
>   
>   	/* Set RAM MR parameters and timings */
> -	for (i = 2; i >= 0; i--) {
> +	for (i = 2; i >= 0; i--)
>   		if (ram_rd32(fuc, mr[i]) != ram->base.mr[i]) {
>   			ram_wr32(fuc, mr[i], ram->base.mr[i]);
>   			ram_nsec(fuc, 1000);
>   		}
> -	}
Idem.
>   
>   	ram_wr32(fuc, 0x100220[3], timing[3]);
>   	ram_wr32(fuc, 0x100220[1], timing[1]);
> @@ -838,11 +835,10 @@ gt215_ram_calc(struct nvkm_ram *base, u32 freq)
>   	if (!next->bios.ramcfg_DLLoff)
>   		nvkm_sddr2_dll_reset(fuc);
>   
> -	if (ram->base.type == NVKM_RAM_TYPE_GDDR3) {
> +	if (ram->base.type == NVKM_RAM_TYPE_GDDR3)
>   		ram_nsec(fuc, 31000);
> -	} else {
> +	else
>   		ram_nsec(fuc, 14000);
> -	}
>   
>   	if (ram->base.type == NVKM_RAM_TYPE_DDR3) {
>   		ram_wr32(fuc, 0x100264, 0x1);

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20160921/01384c94/attachment-0001.html>