[Nouveau] [PATCH 2/2] kms/gf119-: always use a 256-entry lut for now
Ilia Mirkin
imirkin at alum.mit.edu
Sun Dec 31 04:35:29 UTC 2017
Unfortunately the ABI is a little annoying around almost requiring a
256-entry lut. While that is being worked out, allow proper mapping of
colors in 30bpp framebuffers.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
---
If I bump the gamma size to 1024, then all existing software will start
failing since the gamma set ioctl expects the size to match. But
xf86-video-nouveau does not pull in the "real" gaamma size and just
assumes the default 256.
This lets 30bpp get going a bit though while the proper solution is
figured out.
drm/nouveau/nv50_display.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drm/nouveau/nv50_display.c b/drm/nouveau/nv50_display.c
index 0e8f4b76..6ce4467a 100644
--- a/drm/nouveau/nv50_display.c
+++ b/drm/nouveau/nv50_display.c
@@ -1813,7 +1813,7 @@ nv50_head_lut_set(struct nv50_head *head, struct nv50_head_atom *asyh)
evo_data(push, asyh->lut.handle);
} else {
evo_mthd(push, 0x0440 + (head->base.index * 0x300), 4);
- evo_data(push, 0x83000000);
+ evo_data(push, 0x81000000);
evo_data(push, asyh->lut.offset >> 8);
evo_data(push, 0x00000000);
evo_data(push, 0x00000000);
@@ -2214,16 +2214,9 @@ nv50_head_lut_load(struct drm_crtc *crtc)
b = g + crtc->gamma_size;
for (i = 0; i < 256; i++) {
- if (disp->disp->oclass < GF110_DISP) {
- writew((*r++ >> 2) + 0x0000, lut + (i * 0x08) + 0);
- writew((*g++ >> 2) + 0x0000, lut + (i * 0x08) + 2);
- writew((*b++ >> 2) + 0x0000, lut + (i * 0x08) + 4);
- } else {
- /* 0x6000 interferes with the 14-bit color??? */
- writew((*r++ >> 2) + 0x6000, lut + (i * 0x20) + 0);
- writew((*g++ >> 2) + 0x6000, lut + (i * 0x20) + 2);
- writew((*b++ >> 2) + 0x6000, lut + (i * 0x20) + 4);
- }
+ writew((*r++ >> 2) + 0x0000, lut + (i * 0x08) + 0);
+ writew((*g++ >> 2) + 0x0000, lut + (i * 0x08) + 2);
+ writew((*b++ >> 2) + 0x0000, lut + (i * 0x08) + 4);
}
}
--
2.13.6
More information about the Nouveau
mailing list