[Nouveau] [bug report] drm/nouveau/falcon: add msgqueue interface

Dan Carpenter dan.carpenter at oracle.com
Tue Mar 14 07:56:27 UTC 2017


Hello Alexandre Courbot,

This is a semi-automatic email about new static checker warnings.

The patch 9b536e9d5251: "drm/nouveau/falcon: add msgqueue interface" 
from Jan 19, 2017, leads to the following Smatch complaint:

drivers/gpu/drm/nouveau/nvkm/falcon/msgqueue.c:514 nvkm_msgqueue_recv()
	 error: we previously assumed 'queue' could be null (see line 513)

drivers/gpu/drm/nouveau/nvkm/falcon/msgqueue.c
   512	{
   513		if (!queue || !queue->func || !queue->func->recv) {
                    ^^^^^^
Check.

   514			const struct nvkm_subdev *subdev = queue->falcon->owner;
                                                           ^^^^^^^^^^^^^
Dereference.

   515	
   516			nvkm_warn(subdev,

regards,
dan carpenter


More information about the Nouveau mailing list