[Nouveau] [bug report] drm/nouveau/disp/nv50-: add channel interfaces to control error interrupts

Dan Carpenter dan.carpenter at oracle.com
Tue Jun 26 08:49:02 UTC 2018


Hello Ben Skeggs,

The patch a9c44a88ca2f: "drm/nouveau/disp/nv50-: add channel
interfaces to control error interrupts" from May 8, 2018, leads to
the following static checker warning:

	drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c:169 nv50_disp_chan_intr()
	warn: should '65537 << chan->chid.user' be a 64 bit type?

drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
   165  void
   166  nv50_disp_chan_intr(struct nv50_disp_chan *chan, bool en)
   167  {
   168          struct nvkm_device *device = chan->disp->base.engine.subdev.device;
   169          const u64 mask = 0x00010001 << chan->chid.user;
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Can this shift wrap?

   170          const u64 data = en ? 0x00010000 : 0x00000000;
   171          nvkm_mask(device, 0x610028, mask, data);
   172  }

regards,
dan carpenter


More information about the Nouveau mailing list