[Nouveau] [PATCH RFC 00/15] Zero ****s, hugload of hugs <3
Chris Mason
clm at fb.com
Fri Nov 30 20:42:23 UTC 2018
On 30 Nov 2018, at 14:40, Kees Cook wrote:
> On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen
> <jarkko.sakkinen at linux.intel.com> wrote:
>>
>> In order to comply with the CoC, replace **** with a hug.
>
> Heh. I support the replacement of the stronger language, but I find
> "hug", "hugged", and "hugging" to be very weird replacements. Can we
> bikeshed this to "heck", "hecked", and "hecking" (or "heckin" to
> follow true Doggo meme style).
>
> "This API is hugged" doesn't make any sense to me. "This API is
> hecked" is better, or at least funnier (to me). "Hug this interface"
> similarly makes no sense, but "Heck this interface" seems better.
> "Don't touch my hecking code", "What the heck were they thinking?"
> etc... "hug" is odd.
>
> Better yet, since it's only 17 files, how about doing context-specific
> changes? "This API is terrible", "Hateful interface", "Don't touch my
> freakin' code", "What in the world were they thinking?" etc?
I think the bar for changing the documentation/comments should be
improvement in the clarity or approachability of whatever is being
changed.
This patch set is kind of like Linus sitting at kernel summit with a
sign that says "Free Hugs". Kind of confusing, and really unlikely to
make anyone involved happier about working on the kernel.
Jarkko, making things clearer and more approachable is absolutely worth
the time if you're interested, but I think it'll mean larger and more
individualized changes to these files.
-chris
More information about the Nouveau
mailing list