[Nouveau] [PATCH xf86-video-nouveau 2/4] dri2: Mark local create/destroy buffer and copy region functions as static

Rhys Kidd rhyskidd at gmail.com
Mon Jan 21 03:21:32 UTC 2019


Avoids warnings with gcc 8.2:

nouveau_dri2.c:38:1: warning: no previous prototype for ‘nouveau_dri2_create_buffer2’ [-Wmissing-prototypes]
 nouveau_dri2_create_buffer2(ScreenPtr pScreen, DrawablePtr pDraw, unsigned int attachment,
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
nouveau_dri2.c:109:1: warning: no previous prototype for ‘nouveau_dri2_create_buffer’ [-Wmissing-prototypes]
 nouveau_dri2_create_buffer(DrawablePtr pDraw, unsigned int attachment,
 ^~~~~~~~~~~~~~~~~~~~~~~~~~
nouveau_dri2.c:117:1: warning: no previous prototype for ‘nouveau_dri2_destroy_buffer2’ [-Wmissing-prototypes]
 nouveau_dri2_destroy_buffer2(ScreenPtr pScreen, DrawablePtr pDraw, DRI2BufferPtr buf)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
nouveau_dri2.c:131:1: warning: no previous prototype for ‘nouveau_dri2_destroy_buffer’ [-Wmissing-prototypes]
 nouveau_dri2_destroy_buffer(DrawablePtr pDraw, DRI2BufferPtr buf)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
nouveau_dri2.c:137:1: warning: no previous prototype for ‘nouveau_dri2_copy_region2’ [-Wmissing-prototypes]
 nouveau_dri2_copy_region2(ScreenPtr pScreen, DrawablePtr pDraw, RegionPtr pRegion,
 ^~~~~~~~~~~~~~~~~~~~~~~~~
nouveau_dri2.c:215:1: warning: no previous prototype for ‘nouveau_dri2_copy_region’ [-Wmissing-prototypes]
 nouveau_dri2_copy_region(DrawablePtr pDraw, RegionPtr pRegion,
 ^~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>
---
 src/nouveau_dri2.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c
index a726e86..3d53785 100644
--- a/src/nouveau_dri2.c
+++ b/src/nouveau_dri2.c
@@ -34,7 +34,7 @@ static PixmapPtr get_drawable_pixmap(DrawablePtr drawable)
 		return (*drawable->pScreen->GetWindowPixmap)((WindowPtr)drawable);
 }
 
-DRI2BufferPtr
+static DRI2BufferPtr
 nouveau_dri2_create_buffer2(ScreenPtr pScreen, DrawablePtr pDraw, unsigned int attachment,
 			   unsigned int format)
 {
@@ -105,7 +105,7 @@ nouveau_dri2_create_buffer2(ScreenPtr pScreen, DrawablePtr pDraw, unsigned int a
 	return &nvbuf->base;
 }
 
-DRI2BufferPtr
+static DRI2BufferPtr
 nouveau_dri2_create_buffer(DrawablePtr pDraw, unsigned int attachment,
 			   unsigned int format)
 {
@@ -113,7 +113,7 @@ nouveau_dri2_create_buffer(DrawablePtr pDraw, unsigned int attachment,
 					   attachment, format);
 }
 
-void
+static void
 nouveau_dri2_destroy_buffer2(ScreenPtr pScreen, DrawablePtr pDraw, DRI2BufferPtr buf)
 {
 	struct nouveau_dri2_buffer *nvbuf;
@@ -127,13 +127,13 @@ nouveau_dri2_destroy_buffer2(ScreenPtr pScreen, DrawablePtr pDraw, DRI2BufferPtr
 	free(nvbuf);
 }
 
-void
+static void
 nouveau_dri2_destroy_buffer(DrawablePtr pDraw, DRI2BufferPtr buf)
 {
 	nouveau_dri2_destroy_buffer2(pDraw->pScreen, pDraw, buf);
 }
 
-void
+static void
 nouveau_dri2_copy_region2(ScreenPtr pScreen, DrawablePtr pDraw, RegionPtr pRegion,
 			 DRI2BufferPtr pDstBuffer, DRI2BufferPtr pSrcBuffer)
 {
@@ -211,7 +211,7 @@ nouveau_dri2_copy_region2(ScreenPtr pScreen, DrawablePtr pDraw, RegionPtr pRegio
 	FreeScratchGC(pGC);
 }
 
-void
+static void
 nouveau_dri2_copy_region(DrawablePtr pDraw, RegionPtr pRegion,
 			 DRI2BufferPtr pDstBuffer, DRI2BufferPtr pSrcBuffer)
 {
-- 
2.19.1



More information about the Nouveau mailing list