[Nouveau] [PATCH 11/22] mm/hmm: Do not use list*_rcu() for hmm->ranges
Christoph Hellwig
hch at lst.de
Mon Jul 1 06:20:09 UTC 2019
From: Jason Gunthorpe <jgg at mellanox.com>
This list is always read and written while holding hmm->lock so there is
no need for the confusing _rcu annotations.
Signed-off-by: Jason Gunthorpe <jgg at mellanox.com>
Reviewed-by: Jérôme Glisse <jglisse at redhat.com>
Reviewed-by: John Hubbard <jhubbard at nvidia.com>
Acked-by: Souptick Joarder <jrdr.linux at gmail.com>
Reviewed-by: Ralph Campbell <rcampbell at nvidia.com>
Reviewed-by: Ira Weiny <iweiny at intel.com>
Reviewed-by: Christoph Hellwig <hch at lst.de>
Tested-by: Philip Yang <Philip.Yang at amd.com>
---
mm/hmm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/hmm.c b/mm/hmm.c
index 0423f4ca3a7e..73c8af4827fe 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -912,7 +912,7 @@ int hmm_range_register(struct hmm_range *range,
range->hmm = hmm;
kref_get(&hmm->kref);
- list_add_rcu(&range->list, &hmm->ranges);
+ list_add(&range->list, &hmm->ranges);
/*
* If there are any concurrent notifiers we have to wait for them for
@@ -942,7 +942,7 @@ void hmm_range_unregister(struct hmm_range *range)
return;
mutex_lock(&hmm->lock);
- list_del_rcu(&range->list);
+ list_del(&range->list);
mutex_unlock(&hmm->lock);
/* Drop reference taken by hmm_range_register() */
--
2.20.1
More information about the Nouveau
mailing list