[Nouveau] [Bug 111199] New: Bug in dither.depth property set

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=111199

            Bug ID: 111199
           Summary: Bug in dither.depth property set
           Product: xorg
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: max.kammerer at yahoo.com
        QA Contact: xorg-team at lists.x.org

There is probably a bug in dither.depth property set cause its value compared
with dither.mode:

//nouveau_connector.c

if (property == disp->dithering_mode) {
    if (asyc->dither.mode != val) {
        asyc->dither.mode = val;
        asyc->set.dither = true;
    }
} else
if (property == disp->dithering_depth) {
    if (asyc->dither.mode != val) { //Should be dither.depth
        asyc->dither.depth = val;
        asyc->set.dither = true; //triggers dithering regardless of dither.mode
set above. Copy/Paste from above? Should be removed?
    }
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20190723/f840b5bc/attachment.html>