[Nouveau] [PATCH 2/2] drm/nouveau: remove set but not used variable 'mem'

Lyude Paul lyude at redhat.com
Fri Nov 15 18:00:22 UTC 2019


Reviewed-by: Lyude Paul <lyude at redhat.com>

On Fri, 2019-11-15 at 21:42 +0800, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/nouveau/nouveau_ttm.c: In function nouveau_vram_manager_new:
> drivers/gpu/drm/nouveau/nouveau_ttm.c:66:22: warning: variable mem set but
> not used [-Wunused-but-set-variable]
> drivers/gpu/drm/nouveau/nouveau_ttm.c: In function nouveau_gart_manager_new:
> drivers/gpu/drm/nouveau/nouveau_ttm.c:106:22: warning: variable mem set but
> not used [-Wunused-but-set-variable]
> 
> The first 'mem' is introduced by commit 9ce523cc3bf2 ("drm/nouveau:
> separate buffer object backing memory from nvkm structures"),
> but never used, so remove it.
> 
> The second 'mem' is not used since commit d7722134b825 ("drm/nouveau:
> switch over to new memory and vmm interfaces")
> 
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: zhengbin <zhengbin13 at huawei.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_ttm.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c
> b/drivers/gpu/drm/nouveau/nouveau_ttm.c
> index 77a0c6a..7ca0a24 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c
> @@ -63,14 +63,12 @@ nouveau_vram_manager_new(struct ttm_mem_type_manager
> *man,
>  {
>  	struct nouveau_bo *nvbo = nouveau_bo(bo);
>  	struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
> -	struct nouveau_mem *mem;
>  	int ret;
> 
>  	if (drm->client.device.info.ram_size == 0)
>  		return -ENOMEM;
> 
>  	ret = nouveau_mem_new(&drm->master, nvbo->kind, nvbo->comp, reg);
> -	mem = nouveau_mem(reg);
>  	if (ret)
>  		return ret;
> 
> @@ -103,11 +101,9 @@ nouveau_gart_manager_new(struct ttm_mem_type_manager
> *man,
>  {
>  	struct nouveau_bo *nvbo = nouveau_bo(bo);
>  	struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
> -	struct nouveau_mem *mem;
>  	int ret;
> 
>  	ret = nouveau_mem_new(&drm->master, nvbo->kind, nvbo->comp, reg);
> -	mem = nouveau_mem(reg);
>  	if (ret)
>  		return ret;
> 
> --
> 2.7.4
> 
-- 
Cheers,
	Lyude Paul



More information about the Nouveau mailing list