[Nouveau] Getting reviews for nouveau contributions in igt?

Lyude Paul lyude at redhat.com
Thu Jul 2 18:16:11 UTC 2020


Hi! I haven't had much luck asking around in IRC, so I figured this would be the
next place to start. As many of you know I've been working on getting nouveau
into good shape with igt-gpu-tools, now that we've finally finished implementing
CRC support thannks to nvidia's help. I should note that the patches for this
have been accepted into nouveau, Ben's just working on rebasing them on top of
some of the display refactoring + other stuff he's been working on. So they
should appear in drm-tip in the near future, but they're still available on
patchwork for anyone who wants to try them:

   https://patchwork.freedesktop.org/series/78803/
(also needs https://patchwork.freedesktop.org/series/78915/ )

ANYWAY-the first question I had was whether anyone on here would be willing to
help me with getting acks and/or reviews for some of the nouveau-related igt
patches I've sent upstream? One of the patch series adds some nouveau-specific
CRC tests:

   https://patchwork.freedesktop.org/series/74811/

The others add some missing bits to some basic kms tests that I noticed while
doing CRC bringup:

   https://patchwork.freedesktop.org/series/74806/ - fixes false-positives in
   kms_plane plane-position-hole tests

   https://patchwork.freedesktop.org/series/74808/ - adds a test to
   kms_pipe_crc_basic to exercise disabling CRC capture on a pipe immediately
   after said pipe being disabled.

The second question that I had is in the future, for adding nouveau-specific
tests is it acceptable for me to just get reviews from other nouveau developers
or should I be trying to pull people in from this mailing list from outside the
project?



More information about the Nouveau mailing list