[Nouveau] [PATCH v2 4/9] PCI: mark USB4 devices as removable

[Macpaul Lin]

An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20220211/ee9d4355/attachment-0001.htm>
-------------- next part --------------
On 2/11/22 6:43 AM, Mario Limonciello wrote:
> USB4 class devices are also removable like Intel Thunderbolt devices.
> 
> Drivers of downstream devices use this information to declare functional
> differences in how the drivers perform by knowing that they are connected
> to an upstream TBT/USB4 port.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>
> ---
>   drivers/pci/probe.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index e41656cdd8f0..73673a83eb5e 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -1610,6 +1610,7 @@ static void pci_set_removable(struct pci_dev *dev)
>   	 * exposed as "removable" to userspace.
>   	 */
>   	if (vsec ||
> +	    dev->class == PCI_CLASS_SERIAL_USB_USB4 ||
>   	    (parent &&
>   	    (parent->external_facing || dev_is_removable(&parent->dev))))
>   		dev_set_removable(&dev->dev, DEVICE_REMOVABLE);
> 

Reviewed-by: Macpaul Lin <macpaul.lin at mediatek.com>

Thanks!

Regards,
Macpaul Lin