[Nouveau] [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit

Leon Romanovsky leon at kernel.org
Thu Mar 24 18:03:37 UTC 2022


On Wed, Mar 16, 2022 at 12:20:04PM -0700, Randy Dunlap wrote:
> Eliminate anonymous module_init() and module_exit(), which can lead to
> confusion or ambiguity when reading System.map, crashes/oops/bugs,
> or an initcall_debug log.
> 
> Give each of these init and exit functions unique driver-specific
> names to eliminate the anonymous names.
> 
> Example 1: (System.map)
>  ffffffff832fc78c t init
>  ffffffff832fc79e t init
>  ffffffff832fc8f8 t init
> 
> Example 2: (initcall_debug log)
>  calling  init+0x0/0x12 @ 1
>  initcall init+0x0/0x12 returned 0 after 15 usecs
>  calling  init+0x0/0x60 @ 1
>  initcall init+0x0/0x60 returned 0 after 2 usecs
>  calling  init+0x0/0x9a @ 1
>  initcall init+0x0/0x9a returned 0 after 74 usecs
> 
> Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters")
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Cc: Eli Cohen <eli at mellanox.com>
> Cc: Saeed Mahameed <saeedm at nvidia.com>
> Cc: netdev at vger.kernel.org
> Cc: Leon Romanovsky <leon at kernel.org>
> Cc: linux-rdma at vger.kernel.org
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/main.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro at nvidia.com>


More information about the Nouveau mailing list