[Nouveau] [PATCH 2/2] drm/nouveau/clk: avoid usage of list iterator after loop

Lyude Paul lyude at redhat.com
Tue Mar 7 22:50:30 UTC 2023


On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote:
> +		}
>  	}
>  
> +	BUG_ON(!pstate);
>  	nvkm_debug(subdev, "setting performance state %d\n", pstatei);
>  	clk->pstate = pstatei;

We should probably also replace this with

	if (WARN_ON(!pstate)
		return -EINVAL;

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat



More information about the Nouveau mailing list