[Nouveau] [PATCH] mm: Take a page reference when removing device exclusive entries

John Hubbard jhubbard at nvidia.com
Wed Mar 29 03:45:15 UTC 2023


On 3/28/23 20:16, Matthew Wilcox wrote:
...
>> +	if (!get_page_unless_zero(vmf->page))
>> +		return 0;
> 
>  From a folio point of view: what the hell are you doing here?  Tail
> pages don't have individual refcounts; all the refcounts are actually

ohh, and I really should have caught that too. I plead spending too much
time recently in a somewhat more driver-centric mindset, and failing to
mentally shift gears properly for this case.

Sorry for missing that!

thanks,
-- 
John Hubbard
NVIDIA



More information about the Nouveau mailing list