[PATCH] drm/nouveau: nouveau_sched_fini() should check for init failure

Timur Tabi ttabi at nvidia.com
Thu Feb 1 16:20:35 UTC 2024


On Thu, 2024-02-01 at 13:58 +0100, Danilo Krummrich wrote:
> I wonder if we should allocate struct nouveau_sched dynamically instead and
> just
> check for NULL in the corresponding *_fini() functions.
> 
> Actually, in nouveau_abi16_ioctl_channel_alloc() we can omit creating a
> scheduler
> instance entirely if !nouveau_cli_uvmm().

I am all for a better solution if you can think of one.  I don't really like
the idea of "bool initialized", but I couldn't think of a more reliable test.




More information about the Nouveau mailing list