[PATCH] drm/nouveau: create module debugfs root

Danilo Krummrich dakr at kernel.org
Thu Nov 28 10:37:15 UTC 2024


On 11/25/24 6:00 PM, Danilo Krummrich wrote:
> On 11/25/24 5:55 PM, Timur Tabi wrote:
>> On Mon, 2024-11-25 at 15:25 +0100, Danilo Krummrich wrote:
>>> Typically DRM drivers use the DRM debugfs root entry. However, since
>>> Nouveau is heading towards a split into a core and a DRM driver, create
>>> a module specific debugfs root directory.
>>>
>>> Subsequent patches make use of this new debugfs root in order to store
>>> GSP-RM log bufferes (optionally beyond a device driver binding).
>>
>> "buffers">
>>>
>>> Signed-off-by: Danilo Krummrich <dakr at kernel.org>
>>> ---
>>> Unless there are any concerns, I'll pick this patch and rebase 
>>> Timur's patches
>>> on top of it.
>>
>> Well, my only concern is that my code assumes that it is the creator and
>> destroyer of /sys/kernel/debug/nouveau, so I don't think it's going to 
>> be a
>> simple rebase.
> 
> I already did the rebase; no action for you.
> 
> Lifetime wise we're good. We create the debugfs root entry before the 
> driver is registered in module_init() and it's removed after the driver 
> is unregistered in module_exit().

So, if you're fine with that patch, you may want to offer your ACK, such
that I can go ahead and apply the series. :)


More information about the Nouveau mailing list