[PATCH v2 2/3] drm/nouveau: remove unused increment in gm200_flcn_pio_imem_wr

Philipp Stanner pstanner at redhat.com
Tue Aug 5 06:57:42 UTC 2025


On Mon, 2025-08-04 at 14:25 -0500, Timur Tabi wrote:
> The 'tag' parameter is passed by value and is not actually used after
> being incremented, so remove the increment.  It's the function that calls
> gm200_flcn_pio_imem_wr that is supposed to (and does) increment 'tag'.
> 
> Signed-off-by: Timur Tabi <ttabi at nvidia.com>

Reviewed-by: Philipp Stanner <phasta at kernel.org>

> ---
>  drivers/gpu/drm/nouveau/nvkm/falcon/gm200.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/gm200.c b/drivers/gpu/drm/nouveau/nvkm/falcon/gm200.c
> index b7da3ab44c27..6a004c6e6742 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/falcon/gm200.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/falcon/gm200.c
> @@ -103,7 +103,7 @@ gm200_flcn_pio_imem_wr_init(struct nvkm_falcon *falcon, u8 port, bool sec, u32 i
>  static void
>  gm200_flcn_pio_imem_wr(struct nvkm_falcon *falcon, u8 port, const u8 *img, int len, u16 tag)
>  {
> -	nvkm_falcon_wr32(falcon, 0x188 + (port * 0x10), tag++);
> +	nvkm_falcon_wr32(falcon, 0x188 + (port * 0x10), tag);
>  	while (len >= 4) {
>  		nvkm_falcon_wr32(falcon, 0x184 + (port * 0x10), *(u32 *)img);
>  		img += 4;



More information about the Nouveau mailing list